Fix(v4.1): Collapse admin nav on small windows #5990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_backend
tvdeyen
approved these changes
Dec 3, 2024
It is not clear to me why this only fails on some builds, but not others. However, Capybara/Selenium give us a screen size of 800, and a really large browser window of 1920. Let's check for the browser size instead of the screen size, as I've not found a good way of fixing the screen of a Selenium/Capybara session.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4.1 #5990 +/- ##
=======================================
Coverage 88.74% 88.74%
=======================================
Files 563 563
Lines 13883 13883
=======================================
Hits 12320 12320
Misses 1563 1563 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not clear to me why this only fails on some builds, but not others. However, Capybara/Selenium give us a screen size of 800, and a really large browser window of 1920. Let's check for the browser size instead of the screen size, as I've not found a good way of fixing the screen of a Selenium/Capybara session.